disable array reader cache for nested fields#9065
Closed
adriangb wants to merge 1 commit intoapache:mainfrom
Closed
disable array reader cache for nested fields#9065adriangb wants to merge 1 commit intoapache:mainfrom
adriangb wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is the best approach.
While working on Parquet struct filter / projection pushdown I found this limitation.
If you try to read a struct column in both a projection and filter you get a panic that traces back to:
arrow-rs/parquet/src/arrow/array_reader/cached_array_reader.rs
Lines 342 to 344 in 39f0aad
(this causes an upstream panic because the child reader needs to know the nullability of the parent, I think)